Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#161 modified the crate reader to consider entities as data entities if linked not just directly from the root data entity's
hasPart, but also recursively from thehasPartof another data entity. This leads to problems whenhasPartis used on aFileto refer to sections of it. For instance, in ml-predict-pipeline-cwltool-runcrate :{ "@id": "packed.cwl", "@type": ["File", "SoftwareSourceCode", "ComputationalWorkflow", "HowTo"], "hasPart": [ {"@id": "packed.cwl#classify_tumor.cwl"}, {"@id": "packed.cwl#extract_tissue.cwl"} ] }, { "@id": "packed.cwl#classify_tumor.cwl", "@type": "SoftwareApplication" }"packed.cwl#classify_tumor.cwl"is read in as a data entity. This PR changesROCrate.__add_partsto consider onlyhasPartfromDatasetentities.